Skip to content

add grt configs for asap7#3164

Merged
maliberty merged 5 commits into
The-OpenROAD-Project:masterfrom
eder-matheus:asap7_grt_config
May 15, 2025
Merged

add grt configs for asap7#3164
maliberty merged 5 commits into
The-OpenROAD-Project:masterfrom
eder-matheus:asap7_grt_config

Conversation

@eder-matheus

@eder-matheus eder-matheus commented May 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

designs/asap7/mock-alu/rules-base.json updates:

Metric Old New Type
finish__timing__setup__ws -515.34 -521.3 Failing
finish__timing__drv__hold_violation_count 148 116 Tighten

designs/asap7/jpeg/rules-base.json updates:

Metric Old New Type
synth__design__instance__area__stdcell 7117.21 7008.24 Tighten
placeopt__design__instance__area 7801 7648 Tighten
placeopt__design__instance__count__stdcell 66869 65384 Tighten
cts__design__instance__count__setup_buffer 5815 5686 Tighten
cts__design__instance__count__hold_buffer 5815 5686 Tighten
finish__timing__setup__ws 0.0 -54.68 Failing
finish__design__instance__area 7973 7738 Tighten
finish__timing__drv__setup_violation_count 2907 2843 Tighten

@eder-matheus
add grt configs for asap7
246f617 
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
@eder-matheus eder-matheus marked this pull request as draft May 14, 2025 17:39
@eder-matheus
fix min clock layer for asap7/riscv32i-mock-sram
b42438c 
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
@eder-matheus eder-matheus added the UpdateRules Starts GHA to update rules label May 15, 2025
@openroad-ci openroad-ci removed the UpdateRules Starts GHA to update rules label May 15, 2025
oharboe
oharboe reviewed May 15, 2025
View reviewed changes
Comment thread flow/platforms/asap7/config.mk
export MAX_ROUTING_LAYER ?= M7

# Define fastRoute tcl
export FASTROUTE_TCL ?= $(PLATFORM_DIR)/fastroute.tcl

@oharboe oharboe May 15, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now set_macro_extension is no longer invoked.

Is that intentional?

OpenROAD-flow-scripts/flow/scripts/util.tcl

Lines 16 to 26 in 2a81f92

proc fast_route {} {
if {[env_var_exists_and_non_empty FASTROUTE_TCL]} {
log_cmd source $::env(FASTROUTE_TCL)
} else {
log_cmd set_global_routing_layer_adjustment $::env(MIN_ROUTING_LAYER)-$::env(MAX_ROUTING_LAYER) $::env(ROUTING_LAYER_ADJUSTMENT)
log_cmd set_routing_layers -signal $::env(MIN_ROUTING_LAYER)-$::env(MAX_ROUTING_LAYER)
if {[env_var_exists_and_non_empty MACRO_EXTENSION]} {
log_cmd set_macro_extension $::env(MACRO_EXTENSION)
}
}
}

I take it this is somehow related to The-OpenROAD-Project/OpenROAD#7371 ?

@maliberty maliberty May 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main motivation is that I believe the default derates are likely too high. All other PDKs have a fastroute.tcl with lower values. The macro extension is probably not intended though if we don't need it that's fine. Its mostly a workaround for drt issues we have seen in some PDKs.

@eder-matheus eder-matheus May 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oharboe The MACRO_EXTENSION is not used by any design, so it shouldn't have any effect.

Regarding The-OpenROAD-Project/OpenROAD#7371, I intend to review what we're calling regarding GRT configuration and do any necessary cleanup before storing them in ODB. I should start creating PRs for it next week.

@eder-matheus
Merge branch 'master' into asap7_grt_config
6611136
@eder-matheus
bump or again
a140e26 
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
@eder-matheus
update failing metrics
7c11455 
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
@eder-matheus eder-matheus requested a review from maliberty May 15, 2025 21:37
@eder-matheus eder-matheus marked this pull request as ready for review May 15, 2025 21:37
@maliberty

maliberty commented May 15, 2025

Copy link
Copy Markdown
Member

@jeffng-or FYI on asap7 derate change

@maliberty maliberty merged commit 77d1bd6 into The-OpenROAD-Project:master May 15, 2025
7 checks passed
@eder-matheus eder-matheus deleted the asap7_grt_config branch May 19, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maliberty maliberty maliberty approved these changes
+1 more reviewer
@oharboe oharboe oharboe left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eder-matheus @maliberty @oharboe @openroad-ci